[Discover] Data Grid Pagination Options #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishor82
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5610 +/- ##
==========================================
+ Coverage 66.98% 67.03% +0.04%
==========================================
Files 3294 3295 +1
Lines 63318 63329 +11
Branches 10083 10084 +1
==========================================
+ Hits 42416 42451 +35
+ Misses 18448 18429 -19
+ Partials 2454 2449 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kishor82
force-pushed
the
feature/discover-pagination
branch
from
faf0f17 to
9848607
Compare
kishor82
changed the title
kishor82
changed the title
kishor82
force-pushed
the
feature/discover-pagination
branch
from
9848607 to
0efa3c2
Compare
kishor82
commented
Dec 14, 2023
CHANGELOG.md
Outdated
| @@ -945,4 +946,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ### 🔩 Tests | |||
|
|
|||
| - Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322)) | |||
| - Update caniuse to fix failed integration tests ([#2322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2322)) | |||
There was a problem hiding this comment.
Don't know what changed here!
kishor82
force-pushed
the
feature/discover-pagination
branch
from
0efa3c2 to
0a24372
Compare
…lue. Signed-off-by: Kishor Rathva <[email protected]>
Signed-off-by: Kishor Rathva <[email protected]>
Signed-off-by: Kishor Rathva <[email protected]>
kishor82
force-pushed
the
feature/discover-pagination
branch
from
0a24372 to
aed8b0d
Compare
Signed-off-by: Kishor Rathva <[email protected]>
kishor82
force-pushed
the
feature/discover-pagination
branch
from
d208248 to
ed33807
Compare
ruanyl
approved these changes
Dec 19, 2023
ruanyl
approved these changes
Dec 19, 2023
|
Working on functional testing; those are failing due to UI setting value for sampleSize. |
Signed-off-by: kishor82 <[email protected]>
|
@kishor82 thank you. Feel free to reach out if you need any help for functional tst. |
ashwin-pc
approved these changes
Jan 17, 2024
abbyhu2000
approved these changes
Jan 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ashwin-pc
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> (cherry picked from commit e83b7ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this pull request
Feb 5, 2024
* Added helper function to generate page options based on UI setting value. Signed-off-by: Kishor Rathva <[email protected]> * Added dynamic pagination based on config value for data grid table Signed-off-by: Kishor Rathva <[email protected]> * Update changelog Signed-off-by: Kishor Rathva <[email protected]> * Removed service object from the props. Signed-off-by: kishor82 <[email protected]> * Added suggested changes and updated tests. Signed-off-by: kishor82 <[email protected]> * fix functional test issue due to ui setting Signed-off-by: kishor82 <[email protected]> --------- Signed-off-by: Kishor Rathva <[email protected]> Signed-off-by: kishor82 <[email protected]> Signed-off-by: yujin-emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented pagination options based on the Discover UI setting configuration value. #5601 , #5569
Screenshot
closes #5601
closes #5569
Check List
yarn test:jestyarn test:jest_integration